This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix not stopping to peek when navigating away from peeked room #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopPeeking is currently not called when navigating to a joined room after having peeked a room. This causes the /events endpoint for the peeked room to be called until peeking another room, even when not viewing the peeked room anymore. The current code would only stop peeking if you joining were true (note the nesting), e.g. when waiting for your join to be confirmed by /sync. This change might make stopPeeking called also when not needed by there is a guard in that method to do nothing if not currently peeking.
dbkr
approved these changes
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stopPeeking is currently not called when navigating to a joined room
after having peeked a room. This causes the /events endpoint for the
peeked room to be called until peeking another room, even when not
viewing the peeked room anymore.
The current code would only stop peeking if you joining were true (note the nesting),
e.g. when waiting for your join to be confirmed by /sync.
This change might make stopPeeking called also when not needed but there is a guard in
that method to do nothing if not currently peeking.
Came across this while testing the lazy load changes.