Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix UX issues with bug report dialog #1863

Merged
merged 16 commits into from
Apr 30, 2018

Commits on Apr 27, 2018

  1. UI fixes in SessionRestoreErrorDialog

     * Make the 'delete my data' button not the default
     * Make it red
     * Give it a confirmation dialog
     * Remove the 'cancel' button: what does it mean to cancel an error?
       In this case, it tried again and almost certainly got the same error.
     * Remove the top-right 'x' and don't cancel on esc for the same reason.
     * Move 'send bug report' to a button rather than a 'click here' link
     * Add a 'refresh' button which, even if it's no more likely to work,
       will at least look like it's doing something (it's mostly so if you
       don't have a bug report endpoint, there's still a button other
       than the one that deletes all your data).
    dbkr committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    6d9e075 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/dbkr/fix_session_restore_error_h…

    …andling' into dbkr/fix_session_restore_fail_dialog_ux
    dbkr committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    2987e2c View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/dbkr/fix_session_restore_error_h…

    …andling' into dbkr/fix_session_restore_fail_dialog_ux
    dbkr committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    dc06c52 View commit details
    Browse the repository at this point in the history
  4. Fix UX issues with bug report dialog

     * Make it use BaseDialog / DialogButtons (also gives it has a top-right 'x' &
       escape to cancel works)
     * Stop misusing the 'danger' CSS class on the buttons. There is nothing dangerous
       about submitting logs.
     * Continued campaign against 'Click here' links.
    
    Fixes element-hq/element-web#6622
    dbkr committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    efd2919 View commit details
    Browse the repository at this point in the history
  5. Lint

    dbkr committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    27b18c4 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'origin/dbkr/fix_session_restore_fail_di…

    …alog_ux' into dbkr/bug_report_dialog_basedialog
    dbkr committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    74651b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. UI fixes in SessionRestoreErrorDialog

     * Make the 'delete my data' button not the default
     * Make it red
     * Give it a confirmation dialog
     * Remove the 'cancel' button: what does it mean to cancel an error?
       In this case, it tried again and almost certainly got the same error.
     * Remove the top-right 'x' and don't cancel on esc for the same reason.
     * Move 'send bug report' to a button rather than a 'click here' link
     * Add a 'refresh' button which, even if it's no more likely to work,
       will at least look like it's doing something (it's mostly so if you
       don't have a bug report endpoint, there's still a button other
       than the one that deletes all your data).
    dbkr authored and lukebarnard1 committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    fc13660 View commit details
    Browse the repository at this point in the history
  2. Fix UX issues with bug report dialog

     * Make it use BaseDialog / DialogButtons (also gives it has a top-right 'x' &
       escape to cancel works)
     * Stop misusing the 'danger' CSS class on the buttons. There is nothing dangerous
       about submitting logs.
     * Continued campaign against 'Click here' links.
    
    Fixes element-hq/element-web#6622
    dbkr authored and lukebarnard1 committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    37cb8ab View commit details
    Browse the repository at this point in the history
  3. Lint

    dbkr authored and lukebarnard1 committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    a9b6db3 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/develop' into dbkr/fix_session_r…

    …estore_fail_dialog_ux
    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    dcaacfd View commit details
    Browse the repository at this point in the history
  5. Get docs right on hasCancel

    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    5d46efc View commit details
    Browse the repository at this point in the history
  6. Factor out clearStorageButton

    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    54cccab View commit details
    Browse the repository at this point in the history
  7. Indentation

    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    c3420c3 View commit details
    Browse the repository at this point in the history
  8. lint

    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    e28a927 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'dbkr/bug_report_dialog_basedialog' of github.com:matrix…

    …-org/matrix-react-sdk into dbkr/bug_report_dialog_basedialog
    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    d743e6a View commit details
    Browse the repository at this point in the history
  10. Merge remote-tracking branch 'origin/dbkr/fix_session_restore_fail_di…

    …alog_ux' into dbkr/bug_report_dialog_basedialog
    dbkr committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    025bffb View commit details
    Browse the repository at this point in the history