Track duration of page changes #1814
Conversation
The duration measured is between - componentWillUpdate of MatrixChat and - componentDidUpdate of MatrixChat. This does not account for *all* changes to the view that occur when a room switch happens, for example. But it does at least capture the difference between switching to a "big" room and switching to a small test room.
src/Analytics.js
Outdated
| @@ -147,6 +148,23 @@ class Analytics { | |||
| return true; | |||
| } | |||
|
|
|||
| startPageChangeTimer() { | |||
| performance.clearMarks('riot_page_change_start'); | |||
There was a problem hiding this comment.
You'll have to use these APIs conditionally: they aren't available in all browsers.
There was a problem hiding this comment.
https://caniuse.com/#feat=user-timing says otherwise?
There was a problem hiding this comment.
oh yes - MDN lied to me! Fair enough then.
src/Analytics.js
Outdated
| ); | ||
|
|
||
| const measurement = performance.getEntriesByName('riot_page_change_delta').pop(); | ||
| this.generationTimeMs = measurement.duration; |
There was a problem hiding this comment.
The way you're calling this (ie. with willupdate / didupdate) this looks fine, but if these can ever overlap then this will go very wonky, so might be worth calling this out. Also, any reason, not to clear the marks as soon as we have our number?
There was a problem hiding this comment.
might be worth calling this out
As in, with docs on the functions?
Also, any reason, not to clear the marks as soon as we have our number?
Nope, I guess not.
There was a problem hiding this comment.
Yeah, or in conjunction with comment below, change the API so start returns some unique handle that you then pass into trackPageChange? (and remove stopPageChangeTimer). It may be more effort than it's worth though.
src/Analytics.js
Outdated
| @@ -156,6 +174,9 @@ class Analytics { | |||
| return; | |||
| } | |||
| this._paq.push(['setCustomUrl', getRedactedUrl()]); | |||
| if (typeof this.generationTimeMs === 'number') { | |||
| this._paq.push(['setGenerationTimeMs', this.generationTimeMs]); | |||
There was a problem hiding this comment.
Saving this as a member variable seems like quite an error prone API: is trackPageChange() called anywhere else (or will it be in the future?) If so, if the caller doesn't also use the page change timer, it will end up submitting whatever the last page change timer value was.
There was a problem hiding this comment.
True that we'd leak incorrect generation times when we don't use both in conjunction.
We could set it to null after it's been sent?
There was a problem hiding this comment.
See above, but nulling it out is probably acceptable.
The duration measured is between
This does not account for all changes to the view that occur
when a room switch happens, for example. But it does at least
capture the difference between switching to a "big" room and
switching to a small test room.
(as per https://matomo.org/blog/2017/02/how-to-track-single-page-websites-using-piwik-analytics/ - thanks @michaelkaye for finding that!)
Fixes element-hq/element-web#6325