Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Warn users on unsupported browsers before they lack features #12830

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 26, 2024

For https://github.com/element-hq/wat-internal/issues/222

image

Blocked on the Learn more link going nowhere useful

@t3chguy t3chguy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 26, 2024
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Comment on lines +73 to +74
"caniuse-lite": "1.0.30001643",
"electron-to-chromium": "1.5.2"
Copy link
Member Author

@t3chguy t3chguy Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both transitive dependencies of browserslist and forcing resolution de-duplicates them in the bundle

@t3chguy
Copy link
Member Author

t3chguy commented Jul 29, 2024

This PR uses existing toast styles rather than the Figma ones, #12833 brings them back inline

src/SupportedBrowser.ts Outdated Show resolved Hide resolved
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy enabled auto-merge July 29, 2024 15:50
@t3chguy t3chguy added this pull request to the merge queue Jul 29, 2024
Merged via the queue into develop with commit a12c187 Jul 29, 2024
29 checks passed
@t3chguy t3chguy deleted the t3chguy/ua-warning branch July 29, 2024 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants