This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix unwanted ringing of other devices even though the user is already connected to the call. #12742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
suggested changes
Jul 9, 2024
toger5
force-pushed
the
toger5/call-notify-dont-ring-when-already-connected
branch
from
8b09e7d to
42b736b
Compare
toger5
added
the
T-Enhancement
This doesn't make for a very clear changelog entry, please update |
toger5
force-pushed
the
toger5/call-notify-dont-ring-when-already-connected
branch
from
42b736b to
e7efaf6
Compare
toger5
changed the title
toger5
changed the title
toger5
force-pushed
the
toger5/call-notify-dont-ring-when-already-connected
branch
from
e7efaf6 to
bbf1f9b
Compare
t3chguy
reviewed
Jul 16, 2024
Comment on lines
+29
to
+32
| // eslint-disable-next-line no-restricted-imports | ||
| import { MatrixRTCSession } from "matrix-js-sdk/src/matrixrtc/MatrixRTCSession"; | ||
| // eslint-disable-next-line no-restricted-imports | ||
| import { CallMembership } from "matrix-js-sdk/src/matrixrtc/CallMembership"; |
There was a problem hiding this comment.
Ditto. Seems like matrixrtc should have an index with all its public exports and we should allowlist that and consume that
There was a problem hiding this comment.
Thanks for making me finally take care of this...
matrix-org/matrix-js-sdk#4314
and
#12780
I dont think this fits into this PR and I would like to not block this PR on the js-sdk fix (its rather annoying to not have the ringing stop)
So my proposal would be to merge this without the lint rules and I keep the other PR's ontop of this so we can review and merge them independently?
t3chguy
approved these changes
Jul 16, 2024
This is done by checking if a user is already connected to the call on another device before playing the ring sound.
toger5
force-pushed
the
toger5/call-notify-dont-ring-when-already-connected
branch
from
bbf1f9b to
61590b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a call notify event is received but a user is already part of the call (with any other device) no device should ring.
The spec asks clients to never send notify events for already ongoing calls. But since it is possible (and currently happens when EX has not yet synced state when they join a call) it is best to check if the user is connected to the call before ringing.
This is how its expected to behave in the msc text:
matrix-org/matrix-spec-proposals#4075
The updating was already implemented but the check on notify event retrival was missing.
Checklist
public/exportedsymbols have accurate TSDoc documentation.