This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update @vector-im/compound-web & fix jest snapshot updates
#12637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Task
florianduros
force-pushed
the
florianduros/update-compound-web
branch
from
a6d5ef7
to
59c882a
Compare
dbkr
approved these changes
Jun 19, 2024
florianduros
changed the title
florianduros
changed the title
@vector-im/compound-web & fix jest snapshot updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Since this change in
@floating-ui/reactfloating-ui/floating-ui@fa4ee32, the ids used internally by floating-ui are random based. Theses id are used for example for accessibility to link a tooltip to its trigger element.Every run of our tests, theses ids change which is making the snapshot testing unusable.
When we will migrate to react 18,
@floating-ui/reactwill use the built in id generator instead of it's its custom one.Let's fix the resolution of the deps until the our react 18 migration.