Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix/disable failing playwright tests #12402

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 5, 2024

Two tests started failing for reasons I can't correlate with anything. Both pass on my local dev box so I don't have much to go on debugging-wise for either.

  • The presence test appears to be just failing to mark the user as unreachable, which implies the code is actually flakey. I've disabled this test.
  • The long-names timeline test was showing the user's old display name in the MELS. I've changed it to set the display name earlier as per comment.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Unsure why this is failing on CI, it's fine locally. Let's try
setting the display name earlier to see if that fixes it.
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 5, 2024
@dbkr dbkr changed the title Set display name earlier to fix playwright test Fix/disable failing playwright tests Apr 5, 2024
@dbkr dbkr marked this pull request as ready for review April 5, 2024 17:20
@dbkr dbkr requested a review from a team as a code owner April 5, 2024 17:20
@dbkr dbkr added this pull request to the merge queue Apr 5, 2024
Merged via the queue into develop with commit f37821d Apr 5, 2024
34 checks passed
@dbkr dbkr deleted the dbkr/playwright_test_failures branch April 5, 2024 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants