This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Insert pill onClick of timeline profile #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 20, 2017 15:46
When clicking someone in the timeline, insert a user pill instead of the plaintext "displayname:"
This has the advantage of us not reimplementing things and fixing the same bugs twice.
12 tasks
dbkr
reviewed
Jul 20, 2017
| dis.dispatch({ | ||
| action: 'insert_displayname', | ||
| displayname: name.replace(' (IRC)', ''), | ||
| user_id: mxEvent.getSender(), |
There was a problem hiding this comment.
if you're changing this dispatch in a breaking way anyway, might be nice t o rename it to insert_mention or something?
| // paths for inserting a user pill is not fun | ||
| const selection = this.state.editorState.getSelection(); | ||
| const member = this.props.room.getMember(payload.user_id); | ||
| const completion = member ? member.name : payload.user_id; |
There was a problem hiding this comment.
This'll lose the behaviour of stripping the ' (IRC)' suffix - is that intentional?
There was a problem hiding this comment.
Nope, I shall add it back in
dbkr
approved these changes
Jul 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking someone in the timeline, insert a user pill instead of the plaintext "displayname:"