Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Hide the archived section #12286

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Hide the archived section #12286

merged 3 commits into from
Feb 27, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 26, 2024

This just hides the 'Archived' room list section, on the justification that it's somehow weird and a little buggy, and it's better for rooms to just go away once you leave them than hang around and be buggy, although of course it does mean you no longer have access to the history of those rooms.

This just leaves the Archives section in the code, but doesn't display it. A fix was needed in Algorithm because removing it from the order list meant that sometimes we ended up with no such section and Algorithm expects it to exist, so this was the simplest fix. I looked at stripping out the entire existence of the section, but the first problem was that it means that left rooms are just still displayed in the room list, so we'd need to find a way to not show them. Room visibility doesn't work for this because it doesn't expect visibility of a room to change.

Assuming this seems okay, I'll create a bug to remove the archived section entirely. We could also look at removing just the code for forgetting rooms.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

@dbkr dbkr added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 26, 2024
@morguldir
Copy link

Then there wouldn’t be a way to forget rooms either right? At least for me this would result in a really large list of forgotten rooms, if i for example were to use a client with historical rooms, or if the Archive was reintroduced later

@dbkr dbkr added this pull request to the merge queue Feb 27, 2024
Merged via the queue into develop with commit 28f7aac Feb 27, 2024
22 checks passed
@dbkr dbkr deleted the dbkr/hidearchived branch February 27, 2024 10:20
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 13, 2024
https://build.opensuse.org/request/show/1157523
by user dheidler + anag+factory
- Version 1.11.60
  ## ✨ Features
  * Refine styles of controls to match Compound (matrix-org/matrix-react-sdk#12299). Contributed by @robintown.
  * Hide the archived section (matrix-org/matrix-react-sdk#12286). Contributed by @dbkr.
  * Add theme data to EC widget Url (matrix-org/matrix-react-sdk#12279). Contributed by @toger5.
  * Update MSC2965 OIDC Discovery implementation (matrix-org/matrix-react-sdk#12245). Contributed by @t3chguy.
  * Use green dot for activity notification in `LegacyRoomHeader` (matrix-org/matrix-react-sdk#12270). Contributed by @florianduros.
  ## 🐛 Bug Fixes
  * Fix requests for senders to submit auto-rageshakes (https://github.com/matrix-org/ma
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 13, 2024
https://build.opensuse.org/request/show/1157524
by user dheidler + anag+factory
- Version 1.11.60
  ## ✨ Features
  * Refine styles of controls to match Compound (matrix-org/matrix-react-sdk#12299). Contributed by @robintown.
  * Hide the archived section (matrix-org/matrix-react-sdk#12286). Contributed by @dbkr.
  * Add theme data to EC widget Url (matrix-org/matrix-react-sdk#12279). Contributed by @toger5.
  * Update MSC2965 OIDC Discovery implementation (matrix-org/matrix-react-sdk#12245). Contributed by @t3chguy.
  * Use green dot for activity notification in `LegacyRoomHeader` (matrix-org/matrix-react-sdk#12270). Contributed by @florianduros.
  ## 🐛 Bug Fixes
  * Fix requests for senders to submit auto-rageshakes (https://github.com/matrix-org/ma
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants