Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix position & size of dot on the tac button #12199

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 31, 2024

IndicatorIcon doesn't like having the size of its icon adjusted and we probably shouldn't do it anyway: better to specify to the component what size we want it.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fix position & size of dot on the tac button (#12199).

IndicatorIcon doesn't like having the size of its icon adjusted and
we probably shouldn't do it anyway: better to specify to the component
what size we want it.
@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jan 31, 2024
@dbkr dbkr requested a review from a team as a code owner January 31, 2024 16:39
@dbkr dbkr requested review from florianduros and robintown and removed request for a team and robintown January 31, 2024 16:39
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, clearly cleaner :)

@dbkr dbkr changed the title Fox position & size of dot on the tac button Fix position & size of dot on the tac button Jan 31, 2024
@dbkr dbkr merged commit 19c9fcf into florianduros/threads/pop-out-panel Jan 31, 2024
27 checks passed
@dbkr dbkr deleted the dbkr/fix_tac_dot_position branch January 31, 2024 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants