This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Re-use doesRoomHaveUnreadThreads for useRoomThreadNotifications #12195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incorporates the logic of not showing unread dots if the room is muted
dbkr
added
the
T-Defect
dbkr
requested review from
t3chguy and
florianduros
and removed request for
a team and
t3chguy
|
actually this doesn't need to live on the branch. Re-made to target develop: #12196 |
3 tasks
|
...turns out that method is only on the branch, re-opening! |
florianduros
approved these changes
Jan 31, 2024
dbkr
merged commit 6872cc4
into
florianduros/threads/pop-out-panel
34 of 35 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the logic of not showing unread dots if the room is muted
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes