Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Track threads button interaction with Posthog from new room header #11885

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Nov 15, 2023

Fixes element-hq/element-web#26585

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald requested a review from a team as a code owner November 15, 2023 03:41
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 15, 2023
@kerryarchibald kerryarchibald changed the title track WebRoomHeaderButtonsThreadsButton from new room header Track WebRoomHeaderButtonsThreadsButton from new room header Nov 15, 2023
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Before merging, please could you update the summary of the PR to include the word "Posthog"? The word "track" doesn't really help without a bit more context.

@kerryarchibald kerryarchibald changed the title Track WebRoomHeaderButtonsThreadsButton from new room header Track threads button interaction with Posthog from new room header Nov 16, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Nov 16, 2023
Merged via the queue into develop with commit b8ff3c1 Nov 16, 2023
97 of 102 checks passed
@kerryarchibald kerryarchibald deleted the kerry/26585/room-header-posthog branch November 16, 2023 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track room header threads button click
3 participants