Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Avoid importing mkEvent from matrix-js-sdk/spec since that is not in the package #11450

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Avoid importing mkEvent from matrix-js-sdk/spec since that is not in the package #11450

merged 1 commit into from
Aug 23, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Aug 22, 2023 •
edited by github-actions bot
Loading

Attempts to fix this build error that we saw during the release process: https://github.com/matrix-org/matrix-react-sdk/actions/runs/5940228003/attempts/3

2023-08-22T14:52:45.5606965Z ##[debug]$ tsc --emitDeclarationOnly --jsx react
2023-08-22T14:52:45.5607361Z ##[debug]test/components/views/dialogs/RoomSettingsDialog-test.tsx(19,25): error TS2307: Cannot find module 'matrix-js-sdk/spec/test-utils/test-utils' or its corresponding type declarations.

Caused by #11404 linking to test code in matrix-js-sdk from test code in matrix-react-sdk, which doesn't work (and shouldn't work) but there is zero warning from any of our lints or CI for this, which we should definitely fix.

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added T-Task Refactoring, enabling or disabling functionality, other engineering tasks backport staging Label to automatically backport PR to staging branch labels Aug 22, 2023
@andybalaam andybalaam marked this pull request as ready for review August 22, 2023 15:20
@andybalaam andybalaam requested a review from a team as a code owner August 22, 2023 15:20
@andybalaam andybalaam requested review from richvdh and t3chguy August 22, 2023 15:20
@richvdh
Copy link
Member

richvdh commented Aug 22, 2023

Avoid importing mkEvent from matrix-js-sdk/spec since that is not in …

not in?

@andybalaam
Copy link
Member Author

Avoid importing mkEvent from matrix-js-sdk/spec since that is not in …

not in?

image

Sorry, I wrote a too-long comment and github chopped it.

@andybalaam andybalaam enabled auto-merge August 23, 2023 07:02
@andybalaam andybalaam changed the title Avoid importing mkEvent from matrix-js-sdk/spec since that is not in … Avoid importing mkEvent from matrix-js-sdk/spec since that is not in the package Aug 23, 2023
@andybalaam andybalaam added this pull request to the merge queue Aug 23, 2023
Merged via the queue into develop with commit e79b03a Aug 23, 2023
@andybalaam andybalaam deleted the andybalaam/stop-importing-from-spec-js-sdk branch August 23, 2023 10:34
@RiotRobot RiotRobot mentioned this pull request Aug 23, 2023
Merged
RiotRobot pushed a commit that referenced this pull request Aug 23, 2023
@andybalaam @github-actions
Avoid importing mkEvent from matrix-js-sdk/spec since that is not in …
81804b8 
…the package (#11450)

(cherry picked from commit e79b03a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybalaam @richvdh