This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make room model mandatory on the RoomHeader #11355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2023 15:52
It is never used as the RoomHeader is not shown unless a Room model exists
germain-gg
added
the
T-Task
t3chguy
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove
oobDataas it's never actually used in the productFixes element-hq/element-web#25902
For element-hq/element-web#25902
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.