This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Conform more of the codebase to strict types #11162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
| @@ -58,7 +58,7 @@ export type Binding = { | |||
| * https://gist.github.com/jryans/839a09bf0c5a70e2f36ed990d50ed928 | |||
| */ | |||
| export default class AddThreepid { | |||
| private sessionId: string; | |||
| private sessionId?: string; | |||
There was a problem hiding this comment.
It seems odd to me that we have a ? here then lots of ! later on. Couldn't we use the ! here instead?
Think I might be missing something here though
There was a problem hiding this comment.
The type can be undefined, the assertions later are because they'll be handled by the promise rejection. Happy to undo though
There was a problem hiding this comment.
Ok that makes sense - don't see any need to undo
artcodespace
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21967
This change is marked as an internal change (Task), so will not be included in the changelog.