This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve usability of the decryption banner #11012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Enhancement
florianduros
changed the title
richvdh
suggested changes
May 31, 2023
| className = "mx_DecryptionFailureBar"; | ||
| // In developerMode, we want to be able to resend manually key requests | ||
| } else if (developerMode && !needsVerification && hasOtherVerifiedDevices && anyUnrequestedSessions) { | ||
| className = "mx_DecryptionFailureBar mx_DecryptionFailureBar--withEnd"; | ||
| headline = <React.Fragment>{_t("Some messages could not be decrypted")}</React.Fragment>; | ||
| message = ( | ||
| <React.Fragment> |
There was a problem hiding this comment.
per our DM: this message is incorrect now
Comment on lines
144
to
+145
| let button = <React.Fragment />; | ||
| let keyRequestButton = <React.Fragment />; |
There was a problem hiding this comment.
I think we only need one of button and keyRequestButton now
Comment on lines
+174
to
+175
| // In developerMode, we want to be able to resend manually key requests | ||
| } else if (developerMode && !needsVerification && hasOtherVerifiedDevices && anyUnrequestedSessions) { |
There was a problem hiding this comment.
The comment should really be inside the relevant if clause:
Suggested change
| // In developerMode, we want to be able to resend manually key requests | |
| } else if (developerMode && !needsVerification && hasOtherVerifiedDevices && anyUnrequestedSessions) { | |
| } else if (developerMode && !needsVerification && hasOtherVerifiedDevices && anyUnrequestedSessions) { | |
| // In developerMode, show a button to resend key requests if there are other devices we could request keys from. |
| }); | ||
|
|
||
| it("Displays a general error message if there are no other verified devices", async () => { | ||
| it("The banner is hidden if there are no other verified devices", async () => { |
There was a problem hiding this comment.
Suggested change
| it("The banner is hidden if there are no other verified devices", async () => { | |
| it("The banner is hidden if there is a key backup but no other verified devices", async () => { |
There was a problem hiding this comment.
it seems like the code doesn't actually care about key backup or other verified devices?
|
Irrelevant since element-hq/element-meta#1358 (comment) Closing it in favor of #11027. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Closes element-hq/element-meta#1358
Decrypting messages…description by a new onedeveloperModeis enabled, the device is verified, another device is verified and there is a unrequested session. It allows to send manually key request indeveloperMode.Here's what your changelog entry will look like:
✨ Features