Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Apply strictNullChecks to src/components/views/rooms/* #10875

Merged
merged 8 commits into from
May 22, 2023
Merged

Apply strictNullChecks to src/components/views/rooms/* #10875

merged 8 commits into from
May 22, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 12, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#25345
For element-hq/element-web#21967

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 12, 2023
t3chguy
t3chguy approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kerryarchibald kerryarchibald marked this pull request as ready for review May 21, 2023 23:27
@kerryarchibald kerryarchibald requested a review from a team as a code owner May 21, 2023 23:27
@kerryarchibald kerryarchibald added this pull request to the merge queue May 21, 2023
Merged via the queue into develop with commit 74d3018 May 22, 2023
@kerryarchibald kerryarchibald deleted the kerry/25345/snc-views-rooms branch May 22, 2023 00:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply strictNulllChecks to src/components/views/rooms/*
2 participants
@kerryarchibald @t3chguy