Deprecate mx_RightPanel_headerButton class

[luixxiul]

For #10495

This PR intends to deprecate mx_RightPanel_headerButton class in favor of mx_RoomHeader_button to update the header buttons of RoomHeaderButtons by conforming them to our naming policy.

Moving the styles to _RoomHeader.pcss or _RoomHeaderButtons.pcss should be addressed by another PR.

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[luixxiul]

The Jest snapshot update by #10807 was applied.

[germain-gg]

I can get behind the renaming of the CSS class, makes sense 👍
Would you be able to move the CSS in the file you suggested now? That would be quite relevant as part of this changeset. And I don't see the need for a different pull request.

[luixxiul]

And I don't see the need for a different pull request.

Some reviewers prefer to review a PR which is dedicated to a single task, rather than including multiple ones.

Because it has been intended for the sake of a reviewer, it is no problem for myself to create a new CSS file on this PR.

Please wait for a moment…

[germain-gg]

I very much agree with the fact that a pull request should contain one change. I don't think renaming and moving them to a new file should be considered separate in this scenario. It is part of one unit of work.

[luixxiul]

Indeed. I just thought the "single" change in terms of the number 😉

[luixxiul]

The conflict was fixed.

[germain-gg]

Thank you for making the changes! Looks great

[luixxiul]

Thanks for the review!