Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove obsolete class name and declarations on General user settings tab #10659

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Remove obsolete class name and declarations on General user settings tab #10659

merged 3 commits into from
Apr 18, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 18, 2023

This PR suggests to remove obsolete class name and declarations from files forGeneral user settings tab. I have investigated the commit history, and left a comment about which commit deprecated them.

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

The class name was added by aa7afe8 for an initial implementation and became obsolete thanks to 1090b7d.

Signed-off-by: Suguru Hirahara <[email protected]>
The declarations have been obsolete since 11f2b43.

Signed-off-by: Suguru Hirahara <[email protected]>
The declarations have also been deprecated by 11f2b43.

Signed-off-by: Suguru Hirahara <[email protected]>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 18, 2023
@luixxiul luixxiul marked this pull request as ready for review April 18, 2023 19:31
@luixxiul luixxiul requested a review from a team as a code owner April 18, 2023 19:31
@luixxiul luixxiul requested review from dbkr and kerryarchibald April 18, 2023 19:31
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for including the commits that make them obsolete.

@dbkr dbkr added this pull request to the merge queue Apr 18, 2023
Merged via the queue into matrix-org:develop with commit 869856d Apr 18, 2023
@luixxiul
Copy link
Contributor Author

There seems to be other obsolete instances more... I will keep investigating 🔍 🔍

@luixxiul luixxiul deleted the remove-obsolete-css-classname-email-phonenumber branch April 19, 2023 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants