Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use Cypress Testing Library - decryption-failure.spec.ts #10513

Merged
merged 9 commits into from
Apr 6, 2023
Merged

Use Cypress Testing Library - decryption-failure.spec.ts #10513

merged 9 commits into from
Apr 6, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 4, 2023

This PR intends to apply Cypress Testing Library to decryption-failure.spec.ts.

For element-hq/element-web#25033

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 4, 2023
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul marked this pull request as ready for review April 5, 2023 13:20
@luixxiul luixxiul requested a review from a team as a code owner April 5, 2023 13:20
@luixxiul luixxiul requested review from t3chguy and robintown April 5, 2023 13:20
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks certainly cleaner!

@robintown robintown enabled auto-merge (squash) April 5, 2023 18:55
@robintown robintown removed the request for review from t3chguy April 5, 2023 18:56
auto-merge was automatically disabled April 6, 2023 13:41

Merge queue setting changed

@robintown robintown added this pull request to the merge queue Apr 6, 2023
Merged via the queue into matrix-org:develop with commit d820389 Apr 6, 2023
@luixxiul luixxiul deleted the test-decryption-failure branch April 6, 2023 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants