This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix a FilePanel test to have Percy take a snapshot of file tiles on the panel #10429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he panel Signed-off-by: Suguru Hirahara <[email protected]>
github-actions
bot
added
Z-Community-PR
…into test-file-panel
…into test-file-panel
Signed-off-by: Suguru Hirahara <[email protected]>
andybalaam
added
the
X-Needs-Percy
|
The snapshot was taken as expected. Please note that the audio player's seek bar and the timestamp on the bottom next to the profile name are hidden. Checking whether the timestamp is rendered only on the latest updated file would be a next task (element-hq/element-web#24719).
|
luixxiul
commented
Mar 29, 2023
| }); | ||
|
|
||
| // Make the viewport tall enough to display all of the file tiles on FilePanel | ||
| cy.viewport(660, 1000); |
There was a problem hiding this comment.
It is required to check visibility of all of the file tiles. Otherwise it will return an error on the default viewport size (1000, 600).
The viewport size should be reset after each test. Signed-off-by: Suguru Hirahara <[email protected]>
|
Failed due to Percy allowance being used up. It passed previously, so merging. |
|
Thanks for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue reported here that Percy screenshot test for
FilePaneldoes not take a screenshot ofEventTiles onFilePanel, by specifying the correct element and ensuring that they are visible before having Percy take a screenshot.It is recommended to run Percy before merging this PR to check if it works as expected.
type: task
Signed-off-by: Suguru Hirahara [email protected]
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.