-
-
Notifications
You must be signed in to change notification settings - Fork 831
#24408 Issue: Update _AutoHideScrollbar.pcss #10090
#24408 Issue: Update _AutoHideScrollbar.pcss #10090
Conversation
Missing sign off. Please read the document linked. |
@@ -25,7 +25,7 @@ html { | |||
} | |||
|
|||
::-webkit-scrollbar { | |||
width: 6px; | |||
width: 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this make it very different between webkit and non-webkit browsers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ @akshattchhabra can you send screenshots before and after the changes? We should verify, that the scrollbars don't overlap with other content or break the layout. Someone should test the final solution with a non-webkit browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before:
After:
Here, I have attached the screenshots.
So, I checked the solution on a non-webkit browser. Yeah, you are right there would be differences between them and I checked about the possible solutions to make this compatible.
Solution:
To resolve this issue, we need to change the "scrollbar-width: thin" to "scrollbar-width: auto". This will work for the non-webkit browsers. Also, we need to completely remove the webkit-scrollbar css. This will ensure that the scrollbars are wide enough and identical for both kinds of browsers. Please find the attached screenshots for solution.
Webkit browser
This is what I think should be the solution. However, I am not sure if this is correct. Please suggest if you have any other solution.
👋 Is there a corresponding issue associated with this so that I might better understand the problem you're solving and the approach you're taking? |
I'm closing this PR since there's no associated issue and because we don't want the scrollbars to be this wide |
Checklist
Signed-off-by: Akshatt Chhabra [email protected]
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.