Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

#24408 Issue: Update _AutoHideScrollbar.pcss #10090

Conversation

akshattchhabra
Copy link
Contributor

@akshattchhabra akshattchhabra commented Feb 6, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Akshatt Chhabra [email protected]


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@akshattchhabra akshattchhabra requested a review from a team as a code owner February 6, 2023 13:53
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 6, 2023
@t3chguy
Copy link
Member

t3chguy commented Feb 6, 2023

Sign-off given on the changes (see CONTRIBUTING.md)

Missing sign off. Please read the document linked.

@@ -25,7 +25,7 @@ html {
}

::-webkit-scrollbar {
width: 6px;
width: 12px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this make it very different between webkit and non-webkit browsers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ @akshattchhabra can you send screenshots before and after the changes? We should verify, that the scrollbars don't overlap with other content or break the layout. Someone should test the final solution with a non-webkit browser.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

image

After:

image

Here, I have attached the screenshots.

So, I checked the solution on a non-webkit browser. Yeah, you are right there would be differences between them and I checked about the possible solutions to make this compatible.

Solution:
To resolve this issue, we need to change the "scrollbar-width: thin" to "scrollbar-width: auto". This will work for the non-webkit browsers. Also, we need to completely remove the webkit-scrollbar css. This will ensure that the scrollbars are wide enough and identical for both kinds of browsers. Please find the attached screenshots for solution.

Webkit browser

image

non-webkit browser
image

This is what I think should be the solution. However, I am not sure if this is correct. Please suggest if you have any other solution.

@t3chguy t3chguy requested a review from a team February 7, 2023 14:59
@daniellekirkwood
Copy link

👋 Is there a corresponding issue associated with this so that I might better understand the problem you're solving and the approach you're taking?

@robintown
Copy link
Member

@MidhunSureshR
Copy link
Contributor

I'm closing this PR since there's no associated issue and because we don't want the scrollbars to be this wide

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants