This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fixed ScrollBar Collides #10086
Closed
Fixed ScrollBar Collides #10086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
weeman1337
suggested changes
Feb 6, 2023
There was a problem hiding this comment.
Thank you for your contribution @shumakmanohar
Can you add a padding to the scroll container instead? I think it would be better to use an absolute value for the padding instead of a percentage.
Missing sign off, checking the box is not enough, see the linked document. |
|
@shumakmanohar are you able to respond to the review feedback? You also need to add a "Signed-off-by" line to the PR description. I'm going to mark this as Draft for now because it's not ready. Please mark it as Ready for Review when you have made the changes, and re-request review from the reviewers. Thanks! |
|
Linked issue has since been closed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
T-Enhancement
Closes element-hq/element-web#23189
The fix just adds a margin to the right side of the checkbox
Type: [enhancement/defect/task]
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.