use correct default for notification silencing (#9388)

matrix-org · Oct 11, 2022 · 9e055ee · 9e055ee
1 parent 7c1c495
commit 9e055ee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/utils/notifications.ts b/src/utils/notifications.ts
@@ -51,5 +51,5 @@ export async function createLocalNotificationSettingsIfNeeded(cli: MatrixClient)
 export function localNotificationsAreSilenced(cli: MatrixClient): boolean {
     const eventType = getLocalNotificationAccountDataEventType(cli.deviceId);
     const event = cli.getAccountData(eventType);
-    return event?.getContent<LocalNotificationSettings>()?.is_silenced ?? true;
+    return event?.getContent<LocalNotificationSettings>()?.is_silenced ?? false;
 }
diff --git a/test/utils/notifications-test.ts b/test/utils/notifications-test.ts
@@ -81,8 +81,8 @@ describe('notifications', () => {
     });
 
     describe('localNotificationsAreSilenced', () => {
-        it('defaults to true when no setting exists', () => {
-            expect(localNotificationsAreSilenced(mockClient)).toBeTruthy();
+        it('defaults to false when no setting exists', () => {
+            expect(localNotificationsAreSilenced(mockClient)).toBeFalsy();
         });
         it('checks the persisted value', () => {
             mockClient.setAccountData(accountDataEventKey, { is_silenced: true });