Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Only respect X-Needs-Percy in the Merge Queue (#10520)
Browse files Browse the repository at this point in the history
* Enable merge queues

* Iterate

* Iterate

* iterate

* Only respect X-Needs-Percy in the Merge Queue
  • Loading branch information
t3chguy authored Apr 6, 2023
1 parent 818e829 commit 9cecac0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cypress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
if: |
github.event.workflow_run.event == 'schedule' ||
(
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.event == 'merge_queue' &&
contains(fromJSON(steps.prdetails.outputs.data).labels.*.name, 'X-Needs-Percy')
)
run: echo "::set-output name=value::1"
Expand Down
3 changes: 2 additions & 1 deletion docs/cypress.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ nightly build at approximately 04:00 UTC every day. (The schedule is defined in
enabled/disabled in [cypress.yaml](../.github/workflows/cypress.yaml).)

If your pull request makes visual changes, you are encouraged to request Percy
to run by adding the label `X-Needs-Percy` to the PR. This will help us find any
to run by adding the label `X-Needs-Percy` to the PR, these will only run in
the merge queue to save snapshots. This will help us find any
visual bugs or validate visual changes at the time they are made, instead of
having to figure it out later after the nightly build. If you don't have
permission to add a label, please ask your reviewer to do it. Note: it's best to
Expand Down

0 comments on commit 9cecac0

Please sign in to comment.