Remove breadcrumb scroll tolerances and use sensible defaults

Fixes element-hq/element-web#9394 Fixes element-hq/element-web#9400 Numbers chosen based on user feedback. The setting has also been removed because it isn't really needed anymore.
matrix-org · Apr 11, 2019 · 934ca69 · 934ca69
1 parent 86a6037
commit 934ca69
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 36 deletions.
diff --git a/src/components/structures/IndicatorScrollbar.js b/src/components/structures/IndicatorScrollbar.js
@@ -29,13 +29,6 @@ export default class IndicatorScrollbar extends React.Component {
         // scroll horizontally rather than vertically. This should only be used on components
         // with no vertical scroll opportunity.
         verticalScrollsHorizontally: PropTypes.bool,
-
-        // An object containing 2 numbers: xyThreshold and yReduction. xyThreshold is the amount
-        // of horizontal movement required in order to ignore any vertical changes in scroll, and
-        // only applies when verticalScrollsHorizontally is true. yReduction is the factor to
-        // multiply the vertical delta by when verticalScrollsHorizontally is true. The default
-        // behaviour is to have an xyThreshold of infinity and a yReduction of 0.8
-        scrollTolerances: PropTypes.object,
     };
 
     constructor(props) {
@@ -127,20 +120,19 @@ export default class IndicatorScrollbar extends React.Component {
 
     onMouseWheel = (e) => {
         if (this.props.verticalScrollsHorizontally && this._scrollElement) {
-            const xyThreshold = this.props.scrollTolerances
-                ? this.props.scrollTolerances.xyThreshold
-                : Number.MAX_SAFE_INTEGER;
-
-            const yReduction = this.props.scrollTolerances
-                ? this.props.scrollTolerances.yReduction
-                : 0.8;
-
-            // Don't apply vertical motion to horizontal scrolls. This is meant to eliminate
-            // trackpads causing excessive scroll motion.
-            if (e.deltaX >= xyThreshold) return;
-
-            // noinspection JSSuspiciousNameCombination
-            this._scrollElement.scrollLeft += e.deltaY * yReduction;
+            // xyThreshold is the amount of horizontal motion required for the component to
+            // ignore the vertical delta in a scroll. Used to stop trackpads from acting in
+            // strange ways. Should be positive.
+            const xyThreshold = 0;
+
+            // yRetention is the factor multiplied by the vertical delta to try and reduce
+            // the harshness of the scroll behaviour. Should be a value between 0 and 1.
+            const yRetention = 1.0;
+
+            if (Math.abs(e.deltaX) < xyThreshold) {
+                // noinspection JSSuspiciousNameCombination
+                this._scrollElement.scrollLeft += e.deltaY * yRetention;
+            }
         }
     };
 

diff --git a/src/components/views/rooms/RoomBreadcrumbs.js b/src/components/views/rooms/RoomBreadcrumbs.js
@@ -33,12 +33,7 @@ const MAX_ROOMS = 20;
 export default class RoomBreadcrumbs extends React.Component {
     constructor(props) {
         super(props);
-
-        const tolerances = SettingsStore.getValue("breadcrumb_scroll_tolerances");
-        this.state = {rooms: [], scrollTolerances: tolerances};
-
-        // Record this for debugging purposes
-        console.log("Breadcrumbs scroll tolerances:", tolerances);
+        this.state = {rooms: []};
 
         this.onAction = this.onAction.bind(this);
         this._dispatcherRef = null;
@@ -343,8 +338,7 @@ export default class RoomBreadcrumbs extends React.Component {
         });
         return (
             <IndicatorScrollbar ref="scroller" className="mx_RoomBreadcrumbs"
-                trackHorizontalOverflow={true} verticalScrollsHorizontally={true}
-                scrollTolerances={this.state.scrollTolerances}>
+                trackHorizontalOverflow={true} verticalScrollsHorizontally={true}>
                 { avatars }
             </IndicatorScrollbar>
         );

diff --git a/src/settings/Settings.js b/src/settings/Settings.js
@@ -262,13 +262,6 @@ export const SETTINGS = {
         supportedLevels: ['account'],
         default: [],
     },
-    "breadcrumb_scroll_tolerances": {
-        supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS,
-        default: {
-            xyThreshold: 10,
-            yReduction: 0.8,
-        },
-    },
     "analyticsOptIn": {
         supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS_WITH_CONFIG,
         displayName: _td('Send analytics data'),