Merge pull request #2568 from matrix-org/bwindels/fixcollapsesearchterm

Fix: search term disappears when collapsing and expanding left panel
matrix-org · Feb 5, 2019 · 8598c4f · 8598c4f
2 parents 4dd8feb + a6d7f6a
commit 8598c4f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/components/structures/LeftPanel.js b/src/components/structures/LeftPanel.js
@@ -199,9 +199,10 @@ const LeftPanel = React.createClass({
             },
         );
 
-        const searchBox = !this.props.collapsed ?
-            <SearchBox onSearch={ this.onSearch } onCleared={ this.onSearchCleared } /> :
-            undefined;
+        const searchBox = (<SearchBox
+            onSearch={ this.onSearch }
+            onCleared={ this.onSearchCleared }
+            collapsed={this.props.collapsed} />);
 
         return (
             <div className={containerClasses}>

diff --git a/src/components/structures/SearchBox.js b/src/components/structures/SearchBox.js
@@ -95,8 +95,13 @@ module.exports = React.createClass({
     },
 
     render: function() {
-        const TintableSvg = sdk.getComponent('elements.TintableSvg');
-
+        // check for collapsed here and
+        // not at parent so we keep
+        // searchTerm in our state
+        // when collapsing and expanding
+        if (this.props.collapsed) {
+            return null;
+        }
         const clearButton = this.state.searchTerm.length > 0 ?
             (<AccessibleButton key="button"
                     className="mx_SearchBox_closeButton"