Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Fix ResizeHandle of the third pinned widget (#10896)
Browse files Browse the repository at this point in the history
* Revert "Remove unused prop from ResizeHandle - reverse (#10771)"

This reverts commit 62569e2.

* Add a comment
  • Loading branch information
luixxiul authored May 15, 2023
1 parent 70b67fc commit 5988bb9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/components/structures/LoggedInView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ class LoggedInView extends React.Component<IProps, IState> {
resizer.setClassNames({
handle: "mx_ResizeHandle",
vertical: "mx_ResizeHandle--vertical",
reverse: "mx_ResizeHandle_reverse",
});
return resizer;
}
Expand Down
6 changes: 5 additions & 1 deletion src/components/views/elements/ResizeHandle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,21 @@ import React from "react"; // eslint-disable-line no-unused-vars
//see src/resizer for the actual resizing code, this is just the DOM for the resize handle
interface IResizeHandleProps {
vertical?: boolean;
reverse?: boolean;
id?: string;
passRef?: React.RefObject<HTMLDivElement>;
}

const ResizeHandle: React.FC<IResizeHandleProps> = ({ vertical, id, passRef }) => {
const ResizeHandle: React.FC<IResizeHandleProps> = ({ vertical, reverse, id, passRef }) => {
const classNames = ["mx_ResizeHandle"];
if (vertical) {
classNames.push("mx_ResizeHandle--vertical");
} else {
classNames.push("mx_ResizeHandle--horizontal");
}
if (reverse) {
classNames.push("mx_ResizeHandle_reverse"); // required for the resizer of the third pinned widget to work
}
return (
<div ref={passRef} className={classNames.join(" ")} data-id={id}>
<div />
Expand Down
3 changes: 2 additions & 1 deletion src/components/views/rooms/AppsDrawer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
const classNames = {
handle: "mx_ResizeHandle",
vertical: "mx_ResizeHandle--vertical",
reverse: "mx_ResizeHandle_reverse",
};
const collapseConfig = {
onResizeStart: () => {
Expand Down Expand Up @@ -265,7 +266,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
if (i < 1) return app;
return (
<React.Fragment key={app.key}>
<ResizeHandle />
<ResizeHandle reverse={i > apps.length / 2} />
{app}
</React.Fragment>
);
Expand Down

0 comments on commit 5988bb9

Please sign in to comment.