Don't rely on React being fast

matrix-org · Jul 15, 2019 · 2bc0e8e · 2bc0e8e
1 parent c6a18b1
commit 2bc0e8e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/components/structures/auth/Login.js b/src/components/structures/auth/Login.js
@@ -149,24 +149,24 @@ module.exports = React.createClass({
         if (!this.state.serverIsAlive) {
             this.setState({busy: true});
             // Do a quick liveliness check on the URLs
+            let aliveAgain = true;
             try {
                 await AutoDiscoveryUtils.validateServerConfigWithStaticUrls(
                     this.props.serverConfig.hsUrl,
                     this.props.serverConfig.isUrl,
                 );
                 this.setState({serverIsAlive: true, errorText: ""});
             } catch (e) {
+                const componentState = AutoDiscoveryUtils.authComponentStateForError(e);
                 this.setState({
                     busy: false,
-                    ...AutoDiscoveryUtils.authComponentStateForError(e),
+                    ...componentState,
                 });
-                if (this.state.serverErrorIsFatal) {
-                    return; // Server is dead - do not continue.
-                }
+                aliveAgain = !componentState.serverErrorIsFatal;
             }
 
             // Prevent people from submitting their password when something isn't right.
-            if (!this.state.serverIsAlive) {
+            if (!aliveAgain) {
                 return;
             }
         }