Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Revert "Use createObjectURL instead of readAsDataURL for videos"
Browse files Browse the repository at this point in the history
  • Loading branch information
dbkr authored Oct 4, 2018
1 parent a7beb0b commit 2ac951b
Showing 1 changed file with 15 additions and 8 deletions.
23 changes: 15 additions & 8 deletions src/ContentMessages.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,24 @@ function loadVideoElement(videoFile) {
// Load the file into an html element
const video = document.createElement("video");

// Wait until we have enough data to thumbnail the first frame.
video.onloadeddata = function() {
URL.revokeObjectURL(video.src);
deferred.resolve(video);
const reader = new FileReader();
reader.onload = function(e) {
video.src = e.target.result;

// Once ready, returns its size
// Wait until we have enough data to thumbnail the first frame.
video.onloadeddata = function() {
deferred.resolve(video);
};
video.onerror = function(e) {
deferred.reject(e);
};
};
video.onerror = function(e) {
reader.onerror = function(e) {
deferred.reject(e);
};

// We don't use readAsDataURL because massive files and b64 don't mix.
video.src = URL.createObjectURL(videoFile);
reader.readAsDataURL(videoFile);

return deferred.promise;
}

Expand Down

0 comments on commit 2ac951b

Please sign in to comment.