Merge pull request #1858 from matrix-org/luke/fix-piwik-crash3

Fix bug that caused crash when analytics HS/IS whitelists not specified
matrix-org · Apr 26, 2018 · 05f1ca6 · 05f1ca6
2 parents a17c6e1 + 5da62c6
commit 05f1ca6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Analytics.js b/src/Analytics.js
@@ -190,6 +190,7 @@ class Analytics {
     }
 
     _setVisitVariable(key, value) {
+        if (this.disabled) return;
         this._paq.push(['setCustomVariable', customVariables[key].id, key, value, 'visit']);
     }
 
@@ -199,8 +200,8 @@ class Analytics {
         const config = SdkConfig.get();
         if (!config.piwik) return;
 
-        const whitelistedHSUrls = config.piwik.whitelistedHSUrls;
-        const whitelistedISUrls = config.piwik.whitelistedISUrls;
+        const whitelistedHSUrls = config.piwik.whitelistedHSUrls || [];
+        const whitelistedISUrls = config.piwik.whitelistedISUrls || [];
 
         this._setVisitVariable('User Type', isGuest ? 'Guest' : 'Logged In');
         this._setVisitVariable('Homeserver URL', whitelistRedact(whitelistedHSUrls, homeserverUrl));

diff --git a/src/components/structures/MatrixChat.js b/src/components/structures/MatrixChat.js
@@ -352,7 +352,7 @@ export default React.createClass({
                     defaultDeviceDisplayName: this.props.defaultDeviceDisplayName,
                 });
             }).catch((e) => {
-                console.error(`Error attempting to load session: ${e}`);
+                console.error('Error attempting to load session', e);
                 return false;
             }).then((loadedSession) => {
                 if (!loadedSession) {