Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always track our own devices #835

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 6, 2019

It's generally a reasonable assumption that we'll be interested in
them, and important for key backup.

This requires adding the expected /keys/query to just about every place in the crypto integration tests. :( I would add it somewhere common like starting the test client but in theory the request could be aggregated with requesting keys for another user.

Fixes element-hq/element-web#8213

It's generally a reasonable assumption that we'll be interested in
them, and important for key backup.

Fixes element-hq/element-web#8213
@dbkr dbkr requested a review from a team February 6, 2019 16:52
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'm trusting that you've managed to find all the spots in the tests given they passed.

@dbkr dbkr merged commit 9e12fc4 into develop Feb 7, 2019
@t3chguy t3chguy deleted the dbkr/always_track_own_device_list branch August 11, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants