Export ES6 from js-sdk #817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a somewhat experimental PR to make the build process target ES6 rather than ES5 given ES6 is now widely supported. #803
jryans
reviewed
Jan 7, 2019
package.json
Outdated
| "watchify": "^3.11.0" | ||
| "uglify-es": "^3.3.9", | ||
| "watchify": "^3.11.0", | ||
| "webpack": "^4.28.3", |
There was a problem hiding this comment.
Does this package actually use Webpack? It's added here, but it doesn't seem like it's used before or after your changes.
There was a problem hiding this comment.
ah, no it doesn't but I forgot to remove it.
babel-eslint is no longer necessary: ESLint now supports what we need (in this case it was trailing commas). Fix lint errors with a mix of updating lint rules to match our style, minor code fixes and one ignore (I can't see whay it dislikes this one and not the one above...)
|
Tests are currently failing because mocha is exiting with status 1 for no reason. Sigh. |
as the promise in question isn't a bluebird promise and for some reason this matters now where we got away with it before.
|
Fixed one error but it's still unhappy about the abuses we're committing in order to do inheritance in an ES5 world. We probably need to either find the specific thing we're doing wrong here or bite the bullet & port it to real classes. |
|
@dbkr is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat experimental PR to make the build process target
ES6 rather than ES5 given ES6 is now widely supported.
#803