Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'getSsoLoginUrl' function #783

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Add 'getSsoLoginUrl' function #783

merged 2 commits into from
Nov 19, 2018

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 15, 2018 •
edited
Loading

This is in support of MSC1721.

@richvdh richvdh mentioned this pull request Nov 15, 2018
Merged
@richvdh richvdh requested a review from a team November 15, 2018 19:10
turt2live
turt2live approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm. for the default: I'd recommend actually defaulting to "sso" instead of fixing the docs.

src/base-apis.js
* @param {string} redirectUrl The URL to redirect to after the HS
* authenticates with the SSO.
* @param {string} loginType The type of SSO login we are doing (sso or cas).
* Defaults to 'sso'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it defaults to 'cas' below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot.

src/base-apis.js
"redirectUrl": redirectUrl,
}, httpApi.PREFIX_UNSTABLE);
}, httpApi.PREFIX_R0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@richvdh richvdh merged commit 17c11ae into develop Nov 19, 2018
@richvdh richvdh deleted the rav/sso_login_type branch November 19, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @turt2live