Optimise pushprocessor

[lukebarnard1]

by not [re]creating RegExps unnecessarily.

[lukebarnard1]

I am making quite a large assumption about what rule_id is, I may have intuited it totally incorrectly but I couldn't imagine what else it could be apart from a plain user_id or room_id according to the rule type.

[dbkr]

Tests are failing because you've removed the case insensitivity option from the Regex constructor.

But also, you've now assuming all conditions will have either value or regex, but we take conditions from override and underride rules verbatim: these can have patterns too so you'd need to either preprocess these rules to compile the regexes early or fall back to using the pattern if you can't find a value or a regex.

Alternatively, put a cache in globToRegexp.

[lukebarnard1]

Alternatively, put a cache in globToRegexp.

Sounds like a much better, simpler way to go about it.

[dbkr]

Looks good except I think you missed actually looking in the cache?