Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrevert prerelease fix, and fix release error #4353

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Unrevert prerelease fix, and fix release error #4353

merged 2 commits into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. Reapply "Add "type" = "module" to ensure it is present (#4350)" (#4352) 

    This reverts commit 8214fd7.
    @richvdh
    richvdh committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6bdce5b View commit details
    Browse the repository at this point in the history

  2. Mark prettier config file as CommonJS 

    I *think* this will fix a problem with the release process in which we saw an
error:

```
Error:  Invalid configuration for file "/home/runner/work/matrix-js-sdk/matrix-js-sdk/package.json":
Error:  module is not defined in ES module scope
Error:  This file is being treated as an ES module because it has a '.js' file extension and '/home/runner/work/matrix-js-sdk/matrix-js-sdk/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
```
    @richvdh
    richvdh committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2ca07fc View commit details
    Browse the repository at this point in the history