Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Better fallback for unavailable event age" #3870

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Revert "Better fallback for unavailable event age" #3870

merged 1 commit into from
Nov 10, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 9, 2023 •
edited by github-actions bot
Loading

Reverts #3854.

This causes significant logspam, and seems like it needs more thought for various other reasons which I've tried to set out at #3861 (comment).

This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh richvdh requested review from a team as code owners November 9, 2023 17:55
@richvdh richvdh mentioned this pull request Nov 9, 2023
Closed
@richvdh richvdh added the T-Task Tasks for the team like planning label Nov 9, 2023
dbkr
dbkr approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this & doing the reverts.

@richvdh richvdh added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 10, 2023
@t3chguy t3chguy added this pull request to the merge queue Nov 10, 2023
Merged via the queue into develop with commit 437b7ff Nov 10, 2023
23 of 24 checks passed
@t3chguy t3chguy deleted the revert-3854-toger5/better-fallback-for-unavailabel-event-age branch November 10, 2023 03:29
@t3chguy t3chguy added X-Reverted PR has been reverted and removed X-Reverted PR has been reverted labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr dbkr approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richvdh @dbkr @t3chguy