-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RustCrypto | Implement keybackup loop #3652
RustCrypto | Implement keybackup loop #3652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane
# Just use radom bytes for the ratchet parts | ||
ratchet = randbytes(32 * 4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to avoid randomness in this script, so that when we re-run it, only important things change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a static seed to have stable random at each generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just hardcode the strings, rather than having to seed the random generator and call randbytes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me that it has best of the two words, it's stable and later on I can add more keys easilly test key upgrade and more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
There was some confusion about why the cypress tests didn't run on this PR. So: for the record:
|
Implements backup loop for rust crypto.
Fixes https://github.com/vector-im/crypto-internal/issues/113
Depends on:
CryptoApi.checkKeyBackupAndEnable
#3633Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.