Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: Process all verification events, not just requests #3650

Merged
merged 5 commits into from
Aug 9, 2023
Merged

ElementR: Process all verification events, not just requests #3650

merged 5 commits into from
Aug 9, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 4, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • ElementR: Process all verification events, not just requests (#3650). Contributed by @florianduros.

@florianduros florianduros mentioned this pull request Aug 4, 2023
Closed
@florianduros florianduros marked this pull request as ready for review August 7, 2023 16:06
@florianduros florianduros requested a review from a team as a code owner August 7, 2023 16:06
@florianduros florianduros requested review from weeman1337, robintown and richvdh and removed request for weeman1337 and robintown August 7, 2023 16:06
@richvdh richvdh changed the title ElementR: Process all verifications event ElementR: Process all verification events Aug 8, 2023
@richvdh richvdh changed the title ElementR: Process all verification events ElementR: Process all verification events, not just requests Aug 8, 2023
richvdh
richvdh reviewed Aug 8, 2023
View reviewed changes
src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
src/rust-crypto/verification.ts Outdated Show resolved Hide resolved
src/rust-crypto/verification.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/element-r/verification-event branch from 2e69578 to 050f95e Compare August 9, 2023 09:38
richvdh
richvdh approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Aug 9, 2023
Merged via the queue into develop with commit 3a5d660 Aug 9, 2023
20 checks passed
@florianduros florianduros deleted the florianduros/element-r/verification-event branch August 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh