Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementR: Add CryptoApi.requestVerificationDM #3643

Merged
merged 11 commits into from
Aug 21, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jul 31, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@florianduros florianduros marked this pull request as ready for review August 9, 2023 14:20
@florianduros florianduros requested a review from a team as a code owner August 9, 2023 14:20
@florianduros florianduros requested review from dbkr, t3chguy and richvdh and removed request for dbkr and t3chguy August 9, 2023 14:20
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general

src/rust-crypto/verification.ts Outdated Show resolved Hide resolved
spec/integ/crypto/verification.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/verification.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/verification.spec.ts Outdated Show resolved Hide resolved
# Conflicts:
#	spec/test-utils/test-data/generate-test-data.py
#	spec/test-utils/test-data/index.ts
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesomeness ❤️

@florianduros florianduros added this pull request to the merge queue Aug 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2023
@florianduros florianduros added this pull request to the merge queue Aug 21, 2023
Merged via the queue into develop with commit 6bf4ed8 Aug 21, 2023
20 checks passed
@florianduros florianduros deleted the florianduros/element-r/requestVerificationDM branch August 21, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants