Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QRCode: fix breakage on node 16 #3527

Merged
merged 1 commit into from
Jun 29, 2023
Merged

QRCode: fix breakage on node 16 #3527

merged 1 commit into from
Jun 29, 2023

Commits on Jun 28, 2023

  1. QRCode: fix breakage on node 16 

    [`crypto.getRandomValues`](https://nodejs.org/docs/latest-v18.x/api/crypto.html#cryptogetrandomvaluestypedarray)
was added to the nodejs library in node 17. However, it was actually available
in node 16, hiding under
[`crypto.webcrypto`](https://nodejs.org/docs/latest-v16.x/api/webcrypto.html#cryptogetrandomvaluestypedarray). We
have some shims in `src/crypto/crypto.ts`, so let's use them.

All of this means that we don't need to monkey-patch `crypto` to run the tests
on node 16.
    @richvdh
    richvdh committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    278b4b3 View commit details
    Browse the repository at this point in the history