Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close IDB database before deleting it to prevent spurious unexpected close errors #3478

Merged
merged 1 commit into from
Jun 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/store/indexeddb-local-backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -338,12 +338,16 @@ export class LocalIndexedDBStoreBackend implements IIndexedDBBackend {

/**
* Clear the entire database. This should be used when logging out of a client
* to prevent mixing data between accounts.
* to prevent mixing data between accounts. Closes the database.
* @returns Resolved when the database is cleared.
*/
public clearDatabase(): Promise<void> {
return new Promise((resolve) => {
logger.log(`Removing indexeddb instance: ${this.dbName}`);

// Close the database first to avoid firing unexpected close events
this.db?.close();

const req = this.indexedDB.deleteDatabase(this.dbName);

req.onblocked = (): void => {
Expand Down