Improve #3215 implementation #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/tech/improve-one-time-key-count-unused-fallback-keys
branch
from
8fbb149
to
8e5be5b
Compare
florianduros
force-pushed
the
florianduros/tech/improve-one-time-key-count-unused-fallback-keys
branch
from
8e5be5b
to
bc413aa
Compare
|
I know it's still a draft, but could a summary of how you improved the key upload request in your description? |
…unt-unused-fallback-keys
richvdh
requested changes
Apr 3, 2023
florianduros
force-pushed
the
florianduros/tech/improve-one-time-key-count-unused-fallback-keys
branch
from
209b47d
to
1ed4bf5
Compare
richvdh
reviewed
Apr 4, 2023
…unt-unused-fallback-keys
richvdh
approved these changes
Apr 5, 2023
src/crypto/index.ts
Outdated
| this.updateOneTimeKeyCount(oneTimeKeysCounts["signed_curve25519"] || 0); | ||
| } | ||
|
|
||
| if (unusedFallbackKeys) { | ||
| if (unusedFallbackKeys !== undefined) { | ||
| // If `unusedFallbackKeys` is truthy, that means `device_unused_fallback_key_types` |
There was a problem hiding this comment.
Suggested change
| // If `unusedFallbackKeys` is truthy, that means `device_unused_fallback_key_types` | |
| // If `unusedFallbackKeys` is defined, that means `device_unused_fallback_key_types` |
…me-key-count-unused-fallback-keys' into florianduros/tech/improve-one-time-key-count-unused-fallback-keys
…unt-unused-fallback-keys
florianduros
deleted the
florianduros/tech/improve-one-time-key-count-unused-fallback-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Following comments on #3215
Sliding sync change will be done in another PR.
This change is marked as an internal change (Task), so will not be included in the changelog.