-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebRTC media stats collector #3205
Add WebRTC media stats collector #3205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing the review request as this is still a draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but this looks like a good approach. Thanks!
Co-authored-by: David Baker <[email protected]>
…stics' into enricoschw/real-time-media-statistics # Conflicts: # src/webrtc/stats/statsCollector.ts
…l-time-media-statistics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Do we want to keep the stats logging to the console for now? If so, I'd change that to use the logger
wrapper. Otherwise looks great!
@dbkr
(I prefer the first option, but with the option to disable the metrics as well) The next steps for the metrics are: |
I vote option 1 personally. I think the opentelemetry stuff will probably move in to the js-sdk in the long run, but we can get it out into EC with an event in the same way, that sounds ideal for now. |
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.