Abstract publishing #3183
Merged
Abstract publishing #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBrandner
force-pushed
the
SimonBrandner/feat/refactor-publish
branch
from
eae3a4c
to
be3f407
Compare
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
SimonBrandner/feat/refactor-publish
branch
from
be3f407
to
92c86a7
Compare
dbkr
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
I think this makes sense and it seems nice to split these out. If anything, some comments on the classes talking about what the track/feedPublication objects do & represent could be helpful. For instance, why is a FeedPublication necessary over just publishing the two tracks separately?
Signed-off-by: Šimon Brandner <[email protected]>
dbkr
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% happy with the abstraction - let me know if you have any thoughts
This PR currently has none of the required changelog labels.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.