Add support for simulcast #2983
Conversation
Signed-off-by: Šimon Brandner <[email protected]>
…at/simulcast Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
github-actions
bot
requested a deployment
to
PR Documentation Preview
SimonBrandner
requested review from
andybalaam and
weeman1337
and removed request for
a team
src/webrtc/call.ts
Outdated
| } else { | ||
| logger.warn("Didn't find a matching transceiver after adding track!"); | ||
| const parameters = transceiver.sender.getParameters(); | ||
| if (isFirefox()) { |
There was a problem hiding this comment.
Could do with a comment on why the firefox-specific hackery is needed and what has to change so we can get rid of it, especially as it looks like we're doing the same unconditionally on line 856?
There was a problem hiding this comment.
Looking at all of this now, it seems we could probably remove some of the hackery but I am not fully confident yet - have created element-hq/element-call#878 and will look at it ASAP
src/webrtc/call.ts
Outdated
| * @param force - whether or not to force the request to be sent immediately | ||
| */ | ||
| public subscribeToFocus(force = false): void { | ||
| // TODO: Can we throttle this better? |
There was a problem hiding this comment.
lodash.throttle / debounce are your friends
There was a problem hiding this comment.
We don't have lodash in the js-sdk atm, I've created an issue for this to figure out what is the ideal solution - element-hq/element-call#876
There was a problem hiding this comment.
Ah, ok - ftr I'd vote for adding it: it will only pull in the bits you use so it's not expensive.
| rid: SimulcastResolution.Quarter, | ||
| scaleResolutionDownBy: 4.0, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Just to note that the bitrates here are probably defined assuming 720p (ie. what we ask for in getUserMedia) but screenshares will be different resolutions, so these figures might not be as sensible for those (plus of course we may not actually get 720p).
There was a problem hiding this comment.
So I think they are actually not necessary and we should be fine without setting them - let's see 🤞
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
I liked the name better with the changes made |
Signed-off-by: Šimon Brandner <[email protected]>
Thanks to you, too! |
Based on #2423
Here's what your changelog entry will look like:
✨ Features