Correct the units in TURN servers expiry documentation #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shown elsewhere in client.ts, turnServersExpiry really is in milliseconds rather than seconds. It seems that other libraries like matrix-react-sdk were already expecting it to be in milliseconds anyways, so it's just the documentation that was wrong.
t3chguy
approved these changes
Jul 12, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Aug 22, 2022
* Remove unstable support for `m.room_key.withheld` ([\matrix-org#2512](matrix-org#2512)). Fixes matrix-org#2233. * Sliding sync: add missing filters from latest MSC ([\matrix-org#2555](matrix-org#2555)). * Use stable prefixes for MSC3827 ([\matrix-org#2537](matrix-org#2537)). * Add support for MSC3575: Sliding Sync ([\matrix-org#2242](matrix-org#2242)). * Correct the units in TURN servers expiry documentation ([\matrix-org#2520](matrix-org#2520)). * Re-insert room IDs when decrypting bundled redaction events returned by `/sync` ([\matrix-org#2531](matrix-org#2531)). Contributed by @duxovni.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown elsewhere in client.ts,
turnServersExpiryreally is in milliseconds rather than seconds. It seems that other libraries like matrix-react-sdk were already expecting it to be in milliseconds anyways, so it's just the documentation that was wrong.Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes