Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call setEventMetadata() for filtered timelineSets #1765

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jul 2, 2021

Signed-off-by: Šimon Brandner <[email protected]>
@t3chguy t3chguy requested a review from a team July 2, 2021 08:01
Signed-off-by: Šimon Brandner <[email protected]>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/models/event-timeline.ts Outdated Show resolved Hide resolved
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner requested a review from turt2live July 11, 2021 08:51
@turt2live turt2live merged commit 5ce787c into matrix-org:develop Jul 11, 2021
@SimonBrandner SimonBrandner deleted the fix/add-event-meta-for-filtered/5692 branch July 11, 2021 08:51
dbkr added a commit that referenced this pull request Aug 10, 2021
This definitely needs explanation, but hopefully the comment is sufficient.

Type: defect
Fixes element-hq/element-web#18321
Regressed in #1765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants