Rework how disambiguation is handled #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Co-authored-by: Jonathan de Jong <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
…matrix-js-sdk into disambiguate-prop
Signed-off-by: Šimon Brandner <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
|
@ShadowJonathan this contains commits from you - can we get sign off on it please? |
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
disambiguateproperty to theRoomMember. This is useful when a client wants to handle more things on its own. For example, a client may wish to format thedisplayNamedifferently than theuserIdand therefore has to retrieve thedisplayNameanduserNameseparately - it can't rely onjs-sdk's calculation of display names.