Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache normalized room name #1701

Merged
merged 2 commits into from
May 20, 2021
Merged

Cache normalized room name #1701

merged 2 commits into from
May 20, 2021

Conversation

germain-gg
Copy link
Contributor

Fixes element-hq/element-web#17370

Approximatly divides the function execution time by three. Here is the difference of the two call stacks

Before 🐌

Screen Shot 2021-05-20 at 10 42 26

After 🐎

Screen Shot 2021-05-20 at 10 26 33

@germain-gg germain-gg requested a review from a team May 20, 2021 09:48
@germain-gg germain-gg mentioned this pull request May 20, 2021
Merged
t3chguy
t3chguy approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

src/utils.ts Outdated Show resolved Hide resolved
@germain-gg germain-gg merged commit 2422204 into develop May 20, 2021
@germain-gg germain-gg deleted the gsouquet/cache-normalized-name branch May 20, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NameFilterCondition should cache unhomoglyph results
2 participants
@germain-gg @t3chguy